Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Multiple overwrites on rest_controller_class for wp_template/wp_template_part. #48078

Merged

Conversation

jorgefilipecosta
Copy link
Member

With the changes in #45215, we have two filters overwriting rest_controller_class of each other. This PR joins the changes in a single class and fixes the overwriting.

Testing

I created a new template and verified the add template modal appears. On trunk, it does not appear.

@jorgefilipecosta jorgefilipecosta added the [Type] Bug An existing feature does not function as intended label Feb 14, 2023
@github-actions
Copy link

github-actions bot commented Feb 14, 2023

Flaky tests detected in 037d509.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4205049697
📝 Reported issues:

@jorgefilipecosta jorgefilipecosta force-pushed the fix/Multiple-overwrites-on-rest-controller-class branch from e9ffe8c to 2f1cb27 Compare February 16, 2023 15:20
@TimothyBJacobs
Copy link
Member

Code wise this seems good to me.

@jorgefilipecosta jorgefilipecosta force-pushed the fix/Multiple-overwrites-on-rest-controller-class branch from 2f1cb27 to 575d1bb Compare February 17, 2023 14:50
@jorgefilipecosta jorgefilipecosta force-pushed the fix/Multiple-overwrites-on-rest-controller-class branch from 575d1bb to 037d509 Compare February 17, 2023 15:14
@jorgefilipecosta
Copy link
Member Author

Code wise this seems good to me.

Thank you for reviewing 👍

@jorgefilipecosta jorgefilipecosta merged commit 0414d3a into trunk Feb 17, 2023
@jorgefilipecosta jorgefilipecosta deleted the fix/Multiple-overwrites-on-rest-controller-class branch February 17, 2023 16:07
@github-actions github-actions bot added this to the Gutenberg 15.3 milestone Feb 17, 2023
@ramonjd ramonjd added the Needs PHP backport Needs PHP backport to Core label Jun 5, 2023
@oandregal
Copy link
Member

This PR improved on #45215 whose discussion to be backported is happening at https://core.trac.wordpress.org/ticket/57704#comment:4 It missed 6.2 and will probably miss 6.3. Follow trac ticket and original PR for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants