Rich text: remove unnecessary handleSelectionChange call #48373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -33 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6e6cc06. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4257488249
|
ellatrix
added
[Type] Performance
ellatrix
changed the title
ellatrix
force-pushed
the
try/rich-text-focus-micro-task
branch
from
f2d8721
to
6e6cc06
Compare
youknowriad
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Judging by the test results, it seems safe. Any caveats @ellatrix ?
|
No, I think this is safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Setting selection after focus is no longer necessary. It's probably enough to handle it on keyup/mouseup.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast