HTML API: Pull updates from development in Core #48378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flaky tests detected in 79a5406aea243fca05f9a50be758adf79975f7e2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4258643113
|
dmsnell
force-pushed
the
html-api/updates-from-core-dev
branch
from
e23dddd
to
79a5406
Compare
This commit pulls in updates from development of the HTML API happening in Core. - HTML API: Fix finding bookmarks set on closing tag WP_HTML_Tag_Processor 83ae6b790e5f1d361b5b128063f74bf253b55397 - HTML API: Set $this->html to protected to support subclassing 552178a95ad38c924f9d9821d3c75d0bf9926748
dmsnell
force-pushed
the
html-api/updates-from-core-dev
branch
from
79a5406
to
c846c62
Compare
|
Since those changes will be in WP 6.2, we also need to backport them into Gutenberg's 6.2 compat layer. This is done in |
ockham
added a commit
that referenced
this pull request
Mar 2, 2023
In the 6.2 compat layer, support bookmarks pointing to closing tags. This is for parity with Core in WP 6.2, see WordPress/wordpress-develop#4115 and [r55407](https://core.trac.wordpress.org/changeset/55407). Note that these changes have already been backported to GB's 6.**3** compat layer in #48378. However, since the change will be in WP 6.2, we also have to apply it to GB's 6.2 compat layer.
ockham
added a commit
that referenced
this pull request
Mar 2, 2023
In the 6.2 compat layer, support bookmarks pointing to closing tags. This is for parity with Core in WP 6.2, see WordPress/wordpress-develop#4115 and [r55407](https://core.trac.wordpress.org/changeset/55407). Note that these changes have already been backported to GB's 6.**3** compat layer in #48378. However, since the change will be in WP 6.2, we also have to apply it to GB's 6.2 compat layer.
|
Thanks @ockham! - sorry I didn't think about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit pulls in updates from development of the HTML API happening in Core.
HTML API: Fix finding bookmarks set on closing tag WP_HTML_Tag_Processor
83ae6b790e5f1d361b5b128063f74bf253b55397
HTML API: Set $this->html to protected to support subclassing
552178a95ad38c924f9d9821d3c75d0bf9926748
Created by copying tag processor class into
compat/wordpress-6.3and renaming the class.