Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missing translation from label #48760

Conversation

krishneup
Copy link
Contributor

@krishneup krishneup commented Mar 5, 2023

What?

Found the following files missing translations function on the aria-label & settingsLabel attribute

  • packages/block-library/src/columns/edit.native.js
  • packages/block-library/src/comments/edit/placeholder.js

How?

I think we should change codes to like this
settingLabel={ __( 'Width' ) }

aria-label={ __( 'Reply to A WordPress Commenter' ) }

Screenshots or screencast

Screenshot 2023-03-06 at 12 54 24 AM

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 5, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @krishneup! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@krishneup krishneup changed the title Update/missing translations func from blocks Update missing translation from label Mar 5, 2023
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishneup Thanks for the PR. This looks good to me.

@alexstine alexstine added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Block library /packages/block-library [Block] Columns Affects the Columns Block [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop labels Mar 5, 2023
Copy link
Contributor

@michalczaplinski michalczaplinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexstine alexstine merged commit b7aa807 into WordPress:trunk Mar 7, 2023
@github-actions github-actions bot added this to the Gutenberg 15.4 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants