Updated Related Components Links #49176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Related Components Links
skorasaurus
suggested changes
Mar 26, 2023
There was a problem hiding this comment.
Thanks for the PR; the link to the toolbar-button is correct; but the toolbar item link is broken.
i in item from packages/components/src/toolbar/toolbar-Item/ in needs to be lower case.
It should be:
ToolbarGroup may contain [ToolbarButton](/packages/components/src/toolbar/toolbar-button/README.md) and [ToolbarItem](/packages/components/src/toolbar/toolbar-item/README.md) as children.
skorasaurus
added
the
[Type] Developer Documentation
jorgefilipecosta
approved these changes
Sep 6, 2023
|
But as @skorasaurus referred the toolbar item link is broken and I noticed the toolbar link at the top is also broken during the tests. So thank you @skorasaurus for referring this issue as a follow up I will submit a PR fixing the other two links. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Related Components Links
It was missing toolbar/