Update some icons to address aliasing on high-res screens #49381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +902 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Really stellar work. Are you also updating and publishing the Figma library as part of this? The gallery code looks slightly more expansive. Can you maybe run that through https://svgomg.net/? |
I did with one of the Figma plugins, ran it again. I can't seem to get it without
Yes! I have them ready, was waiting for approval first. I'll move these standouts into the actual icon components when we're merged here.
|
jasmussen
approved these changes
Mar 29, 2023
|
Flaky tests detected in 0032169. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4568100299
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ##49311, focusing on common blocks/UI icons first. Updates a few icons to remove the aliasing that occurs on high-resolution screens.
Why?
We want our icons to look crisp and present well.
How?
Updating icons within the icons package. This does not change the spirit of the icons, just adjusts the icon paths a little to not use
0.25X and Y values.Testing Instructions
Check the icons in the following locations:
Screenshots or screencast