Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing useState import in Border Control documentation. #49476

Merged
merged 8 commits into from Sep 11, 2023
Merged

Add missing useState import in Border Control documentation. #49476

merged 8 commits into from Sep 11, 2023

Conversation

chintu51
Copy link
Contributor

No description provided.

@talldan
Copy link
Contributor

talldan commented Mar 31, 2023 •
edited

@chintu51 Thanks for updating this.

Maybe this line could also be removed:

const onChange = ( newBorder ) => setBorder( newBorder );

The function doesn't seem to do anything useful, setBorder could be passed straight to the BorderControl onChange prop.

jorgefilipecosta
jorgefilipecosta approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems some time already passed since @talldan comment. I guess we can merge this PR so we avoid keeping it open and I will address the other @talldan comment as a follow-up.
Thank you for this fix @chintu51!

@jorgefilipecosta jorgefilipecosta merged commit bb4ed88 into WordPress:trunk Sep 11, 2023
43 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 11, 2023
@jorgefilipecosta jorgefilipecosta mentioned this pull request Sep 11, 2023
Merged
@mikachan mikachan added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chintu51 @talldan @jorgefilipecosta @mikachan @tomjn @spacedmonkey