Fix: Demo content cover block alignment not respected #49848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Codewise this looks good to me, and since it's such a small change I'd be happy to give a ✅ . However I'm using Local for my env, and the demo content doesn't work in that setup, so I'm unable to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #28476
What?
This PR fixes a problem where the width of the cover block cannot be changed in the demo content.
0ccfcd01d6ef999a3335a90d1d4c1412.mp4
Why?
It is visually wide, but this is because the
alignwideclass is specified directly in the additional css class, not set in the block toolbar. Therefore, if you select Node or Center in the block toolbar, the width will not change because thealignwideclass will remain.How?
As far as I know, alignwide/alignfull has never been controlled by additional CSS in the past, but always as an
alignattribute. Therefore, I believe this is a simple HTML error.Testing Instructions
Apply None or Center in the block toolbar and make sure it is applied correctly to both the editor and the front end.
Note: If you have saved the demo content at least once, please delete it from the post list.