Update index.js #50192
Open
Update index.js #50192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TextTransformControl is still experimental. It should be marked as such in the title. So that newer developers might not get confused while importing it from '@wordpress/block-editor'
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @2xSamurai! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
jorgefilipecosta
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Thank you @2xSamurai, I agree marking the component as an experiment makes things clear.
|
Would you be able to rebase the PR so that it can be merged? Thank you in advance! |
t-hamano
added
[Package] Block editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextTransformControl is still experimental. It should be marked as such in the title. So that newer developers might not get confused while importing it from '@wordpress/block-editor'
What?
The TextTransformControl is not marked as experimental in the Guttenberg Storybook.
Why?
Im not sure whether this is intended or not. But I tried to import it directly from '@wordpress/block-editor' and was faced with errors. I feel if there was an experimental tag somewhere then it would have been much more helpful since there is no other documentation to be found anywhere regarding this.
How?
I just updated the title to be similar to the ones for the experimental components.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast