-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lodash: Refactor away from _.mapValues()
#50285
Conversation
Size Change: +3 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Flaky tests detected in f3cdeac. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4871002354
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke-tested the editors. I couldn't spot any regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What?
This PR removes the last usage of Lodash's
_.mapValues()
and deprecates the function.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetch
package haslodash
as a dependency #39495How?
We're using
Object.fromEntries( Object.entries().map() )
as a replacement.Testing Instructions
Verify all checks are green. The changes are covered by existing tests and checks.