Added a check for null as well #50461
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @CryZo! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
| @@ -132,7 +132,7 @@ export default function useSetting( path ) { | |||
| blockName | |||
| ); | |||
|
|
|||
| if ( undefined !== result ) { | |||
| if ( undefined !== result || null !== result ) { | |||
There was a problem hiding this comment.
Can we just do this instead?
| if ( undefined !== result || null !== result ) { | |
| if ( ! result ) { |
This is one drawback to JavaScript.
There was a problem hiding this comment.
Sure :) I thought it had an purpose, that result was checked that explicit there. But I would suggest to solve it on both if statements like this.
There was a problem hiding this comment.
I changed it in the other if statements as well. I hope it fits better now?
There was a problem hiding this comment.
One more thing: I noticed, that the last commits on trunk failed. So my changes may be innocent.
mirka
added
[Package] Block editor
What?
This PR adds a null check to the
use-settingcomponent.Why?
Because we had the case, that a combination of a faulty
theme.jsonand ACF blocks crashed the Gutenberg editor on one of customers websites - on production! -.- Tn this case the components constructor gotnullinstead ofundefinedor a valid component data model.How?
I added a null check as well.
Testing Instructions
Unfortunately I have no clue how exactly we got there. However the more stable this code gets, the better - right?
Testing Instructions for Keyboard
n/a