Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coding-standards issues #50656

Merged
merged 1 commit into from May 16, 2023
Merged

Fix coding-standards issues #50656

merged 1 commit into from May 16, 2023

Conversation

aristath
Copy link
Member

What?

Just fixing some coding-standards issues that come up when I run vendor/bin/phpcs . locally.
The errors are in the test themes we use and we could just ignore these files, but there's no reason why we can't just fix them 馃し

Why?

Because these errors & warnings are annoying

@aristath aristath requested a review from Mamaduka May 16, 2023 09:29
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks, Ari!

@aristath aristath merged commit 283c674 into trunk May 16, 2023
50 checks passed
@aristath aristath deleted the fix/cs-errors branch May 16, 2023 10:19
@github-actions github-actions bot added this to the Gutenberg 15.9 milestone May 16, 2023
@cbravobernal cbravobernal added [Type] Code Quality Issues or PRs that relate to code quality [Package] E2E Tests /packages/e2e-tests labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Tests /packages/e2e-tests [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants