Nav Browse mode remove "ghost" Nav block #50847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +36 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0a3227b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5046996714
|
|
The problem here is that we deprecated the Unfortunately in our scenario we don't have a root because these blocks (i.e. those from the @scruffian as you deprecated |
|
The reason for deprecating |
I think the block is also being used to load the navigation menus. |
Nope. We're doing that already. @talldan had some ideas in #49475 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
WIP to try and replace need for hidden/ghost Nav block within the Navigation seciton of Browse Mode.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast