Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Modal Heading and Label text color value #50916

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

falgunihdesai
Copy link
Contributor

@falgunihdesai falgunihdesai commented May 24, 2023

Update the Modal Heading and Label text color value so that it matches with the text color used for other areas of the editor. Previously it was using color from wp-admin common.css. Fixes #50448

What?

Why?

How?

Testing Instructions

  1. Open the WordPress page editor.2.
  2. Open the Preferences modal and check the colour value using inspect element.

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2023-05-24 at 2 56 21 PM Screenshot 2023-05-24 at 2 55 49 PM

Update the Modal Heading and Label text color value so that it matches with the text color used for other areas of the editor.
Previously it was using color from wp-admin common.css. Fixes WordPress#5044
@mtias mtias added the Needs Design Feedback Needs general design feedback. label Jun 2, 2023
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing regressions and this seems to work. Thank you for this PR @falgunihdesai.

@jorgefilipecosta
Copy link
Member

I'm going to cc: @richtabor to double-check if this is the expected result from the UX point of view.

@richtabor richtabor self-requested a review September 13, 2023 21:38
@github-actions
Copy link

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: Needs Design Feedback.

Read more about Type labels in Gutenberg.

Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal headings and labels missing editor text color
4 participants