New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Modal Heading and Label text color value #50916
base: trunk
Are you sure you want to change the base?
Update the Modal Heading and Label text color value #50916
Conversation
Update the Modal Heading and Label text color value so that it matches with the text color used for other areas of the editor. Previously it was using color from wp-admin common.css. Fixes WordPress#5044
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing regressions and this seems to work. Thank you for this PR @falgunihdesai.
I'm going to cc: @richtabor to double-check if this is the expected result from the UX point of view. |
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update the Modal Heading and Label text color value so that it matches with the text color used for other areas of the editor. Previously it was using color from wp-admin common.css. Fixes #50448
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast