Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: Fix design of close button for the lightbox (correct PR) #51206

Merged
merged 10 commits into from
Jun 6, 2023
Merged

Image: Fix design of close button for the lightbox (correct PR) #51206

merged 10 commits into from
Jun 6, 2023

Commits on Jun 5, 2023

  1. Revise CSS to contain images within overlay properly

    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    32ba82d View commit details
    Browse the repository at this point in the history

  2. Set horizontal images to occupy space of container

    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a6d608a View commit details
    Browse the repository at this point in the history

  3. Make square images fit by height rather than expand to full width

    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    320bf33 View commit details
    Browse the repository at this point in the history

  4. Revise so lightbox loads original image; remove padding and hide caption 

    The lightbox will now load the original image when opened;
the src attribute is set dynamically so it will not be
unnecessarily loaded by the browser.

In addition, removed the padding and hid the caption.
    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    85fe4a6 View commit details
    Browse the repository at this point in the history

  5. Fix PHP spacing for linter

    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9d80752 View commit details
    Browse the repository at this point in the history

  6. Fix test; image src is now only set after lightbox opens

    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    c2b9a4c View commit details
    Browse the repository at this point in the history

  7. Improve styles for lightbox close button

    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    27c2347 View commit details
    Browse the repository at this point in the history

  8. Fix PHP spacing for linter

    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a1194fe View commit details
    Browse the repository at this point in the history

  9. Darken the scrim

    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    2850a77 View commit details
    Browse the repository at this point in the history

  10. Remove obsolte code

    @artemiomorales
    artemiomorales committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    f829b7c View commit details
    Browse the repository at this point in the history