Image Lightbox: Add a reset button. #51239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Enhancement
|
Size Change: +1.69 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7a97ee1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5187104685
|
SantosGuillamot
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
I've tested it and it seems to work as expected 🙂 Thanks for the pull request!
I don't love the extra <div> to prevent the margin bottom, but I cannot think of another way of doing it right now. Anyway, I believe it should be enough for this initial version. We can always change it in the future.
ndiego
added
[Type] Experimental
33 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Add a reset button, e2e tests still pending * Add e2e tests to reset button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a
resetbutton to the behaviors that removes the attribute from the block code. The behavior applied in this case would be the default one set in thetheme.jsonfile.Why?
Right now, if the user chooses a behavior, it will stay in the block markup forever, being true or false. This way the user can remove it and the default will be applied.
How?
Adding a reset a button.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2023-06-05.at.18.07.29.mov
The e2e tests will come in a new PR if this one gets merged before I finish them.: Added