Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Block Theme Previews] Change the URL query string for more safety #51312

Merged
merged 1 commit into from Jun 8, 2023
Merged

[Block Theme Previews] Change the URL query string for more safety #51312

merged 1 commit into from Jun 8, 2023

Conversation

okmttdhr
Copy link
Contributor

@okmttdhr okmttdhr commented Jun 8, 2023 •
edited

What?

Changed the URL query string name to trigger Block Theme Previews (from ?theme_preview to ?gutenberg_theme_preview).

Why?

The original URL query string had a wide impact in terms of WordPress context. (e.g. WordPress.com is using $_GET['theme_preview'] as well). c.f. #50983 (comment)

Testing Instructions

  • Go to /wp-admin/themes.php
  • Click the Live Preview button on a theme installed

or

  • Open the Site Editor and add the following to your URL: ?gutenberg_theme_preview=[themePath] where themePath is the relative path to the theme you want to preview (e.g. twentytwentythree).

Screenshots or screencast

Screen.Recording.2023-06-08.at.10.42.17.2.small.mov

@okmttdhr okmttdhr marked this pull request as ready for review June 8, 2023 01:46
@okmttdhr okmttdhr mentioned this pull request Jun 8, 2023
Merged
scruffian
scruffian approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scruffian scruffian merged commit bdf728b into WordPress:trunk Jun 8, 2023
49 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 8, 2023
scruffian
scruffian approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okmttdhr okmttdhr deleted the update/block-theme-previews-url-query branch June 8, 2023 08:02
@ramonjd ramonjd mentioned this pull request Jun 9, 2023
Closed
@MaggieCabrera MaggieCabrera mentioned this pull request Jun 16, 2023
Closed
8 tasks
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@okmttdhr @sethrubenstein
Change the URL query string for more safety (WordPress#51312)
cd8a862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scruffian scruffian scruffian approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@mmtr mmtr Awaiting requested review from mmtr mmtr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 16.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@okmttdhr @scruffian