Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createI18n package import location #51328

Merged
merged 1 commit into from Sep 8, 2023

Conversation

jamiemchale
Copy link
Contributor

createI18n is exported from i18n package,
not from react-i18n package.

What?

Fixing a documentation code example typo.

Why?

Because the code example does not run correctly without this fix.

How?

It is a documentation change.

Testing Instructions

To test the actual code, try importing createI18n from @wordpress/react-i18n. It will fail. Then try from @wordpress/i18n and it will success.

Testing Instructions for Keyboard

n/a

createI18n is exported from i18n package,
not from react-i18n package.
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jamiemchale! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jun 9, 2023
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@jorgefilipecosta jorgefilipecosta merged commit b92d4f8 into WordPress:trunk Sep 8, 2023
47 of 48 checks passed
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Congratulations on your first merged pull request, @jamiemchale! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants