Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused prop from GroupPlaceHolder component #51493

Merged
merged 1 commit into from Sep 6, 2023
Merged

Remove unused prop from GroupPlaceHolder component #51493

merged 1 commit into from Sep 6, 2023

Conversation

ediamin
Copy link
Contributor

@ediamin ediamin commented Jun 14, 2023

What?

The GroupPlaceHolder component does not have any clientId prop, so adding this prop in the GroupEdit component has no effect. This PR simply removes this unused prop in the GroupEdit component.

Why?

The clientId prop has no effect in GroupPlaceHolder component.

How?

Simply removed the prop.

@ediamin ediamin requested a review from ajitbohra as a code owner June 14, 2023 12:29
jorgefilipecosta
jorgefilipecosta approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @ediamin 👍 Thank you!

@jorgefilipecosta jorgefilipecosta merged commit 8445577 into WordPress:trunk Sep 6, 2023
27 of 49 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 6, 2023
@ediamin ediamin deleted the remove-unused-prop-from-group-placeholder branch September 7, 2023 07:00
@mikachan mikachan added [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ediamin @jorgefilipecosta @mikachan