Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Navigable toolbar test to Playwright #51514

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
104 changes: 0 additions & 104 deletions packages/e2e-tests/specs/editor/various/navigable-toolbar.test.js

This file was deleted.

47 changes: 47 additions & 0 deletions test/e2e/specs/editor/various/navigable-toolbar.spec.js
@@ -0,0 +1,47 @@
/**

Check failure on line 1 in test/e2e/specs/editor/various/navigable-toolbar.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 2

[chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page

1) [chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page Test timeout of 100000ms exceeded.

Check failure on line 1 in test/e2e/specs/editor/various/navigable-toolbar.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 2

[chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page

1) [chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Test timeout of 100000ms exceeded.

Check failure on line 1 in test/e2e/specs/editor/various/navigable-toolbar.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 2

[chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page

1) [chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Test timeout of 100000ms exceeded.

Check failure on line 1 in test/e2e/specs/editor/various/navigable-toolbar.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 2

[chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page

1) [chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Pending operations: - keyboard.press at test/e2e/specs/editor/various/navigable-toolbar.spec.js:21:25
* WordPress dependencies
*/
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' );

test.describe( 'Block Toolbar', () => {
test.beforeEach( async ( { admin } ) => {
await admin.createNewPost();
} );

test.describe( 'Contextual Toolbar', () => {
test( 'should not scroll page', async ( { page, pageUtils } ) => {
while (
await page.evaluate( () => {
const scrollable = window.wp.dom.getScrollContainer(
document.activeElement
);
return ! scrollable || scrollable.scrollTop === 0;
} )
) {
await page.keyboard.press( 'Enter' );

Check failure on line 21 in test/e2e/specs/editor/various/navigable-toolbar.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 2

[chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page

1) [chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page Error: keyboard.press: Target closed 19 | } ) 20 | ) { > 21 | await page.keyboard.press( 'Enter' ); | ^ 22 | } 23 | 24 | await page.keyboard.type( 'a' ); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/navigable-toolbar.spec.js:21:25

Check failure on line 21 in test/e2e/specs/editor/various/navigable-toolbar.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 2

[chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page

1) [chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: keyboard.press: Target closed 19 | } ) 20 | ) { > 21 | await page.keyboard.press( 'Enter' ); | ^ 22 | } 23 | 24 | await page.keyboard.type( 'a' ); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/navigable-toolbar.spec.js:21:25

Check failure on line 21 in test/e2e/specs/editor/various/navigable-toolbar.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 2

[chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page

1) [chromium] › editor/various/navigable-toolbar.spec.js:12:3 › Block Toolbar › Contextual Toolbar › should not scroll page Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: keyboard.press: Target page, context or browser has been closed 19 | } ) 20 | ) { > 21 | await page.keyboard.press( 'Enter' ); | ^ 22 | } 23 | 24 | await page.keyboard.type( 'a' ); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/navigable-toolbar.spec.js:21:25
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why yet, but when I run this test locally and watch it in the browser, it gets stuck in a cycle of pressing Enter over and over without moving on to the code after it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something got messed up during a copy/paste or search/replace. I copy/pasted the old test from [navigable-toolbar.test](https://raw.githubusercontent.com/WordPress/gutenberg/6c0f4a50324b7f09b4c13c8ce2b974b1e2243bd1/packages/e2e-tests/specs/editor/various/navigable-toolbar.test.js) and replaced the expect( await isInBlockToolbar() ).toBe( true ); part, and the test passes.

Could you try copy/pasting it again and see if it works for you?


await page.keyboard.type( 'a' );

const scrollTopBefore = await page.evaluate(
() =>
window.wp.dom.getScrollContainer( document.activeElement )
.scrollTop
);
await pageUtils.pressKeys( 'alt+F10' );
await expect(
page
.getByRole( 'toolbar', { name: 'Block Tools' } )
.getByRole( 'button', { name: 'Paragraph' } )
).toBeFocused();

const scrollTopAfter = await page.evaluate(
() =>
window.wp.dom.getScrollContainer( document.activeElement )
.scrollTop
);

expect( scrollTopBefore ).toBe( scrollTopAfter );
} );
} );
} );