New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Details: Set 'clientId' as useSelect dependency #51634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
carolinan and
t-hamano
and removed request for
ajitbohra
June 19, 2023 07:22
Mamaduka
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Block] Details
Affects the Details Block - used to display content which can be shown/hidden
labels
Jun 19, 2023
Size Change: +2 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Flaky tests detected in 46b1244. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5309005568
|
carolinan
approved these changes
Jun 19, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Details
Affects the Details Block - used to display content which can be shown/hidden
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes
React Hook useSelect has a missing dependency: 'clientId'
ESLint warning in the Details block.Why?
Missing dependencies can have unexpected side effects.
Testing Instructions
Confirm the Details block works as before.