Add documentation describing block transforms #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Feb 22, 2018
| content, | ||
| } ); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Should we stop here in this example and leave the shortcode for another example (to match the text above)?
youknowriad
reviewed
Feb 22, 2018
docs/block-api.md
Outdated
|
|
||
| For example, a paragraph block can be transformed into a heading block. | ||
|
|
||
| ```js |
There was a problem hiding this comment.
Should we do an es5/esnext version like the other examples in the handbook?
|
Thanks for this, left a minor comment but this is looking good for a start. I think we probably want to move these to a separate file at some point because there's a lot to say about transforms, but it's fine for now. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first pass on the documentation on defining block transforms. There's a couple transform types I haven't used before (regular expression, raw DOM node) that I could use some explanations for myself so I can add them to the docs.