Update mismatched package json files #52145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
requested review from
adamsilverstein,
swissspidy,
ellatrix,
ajitbohra,
gziolo,
ntwb,
nerrad,
dmsnell and
mmtr
as code owners
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 36ff9a8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5417402027
|
|
This resolved itself in the most recent automated package update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some folks noticed that our npm package versions don't match the local package.json files. (For example,
@wordpress/hooksis at version 3.36.0 on npm, but 3.35.0 in the package.json file. This fixes those!Question: Is it critical to also update the changelogs, or will the next release get those automatically?
Why?
I think this happened whenever folks were releasing hotfixes for the WordPress release? I saw some Slack messages about needing something released quickly outside of the normal process. Because normally, these are all updated automatically by the package update process, so I'm guessing something in the process might have been accidentally skipped.
How?
I wrote a script which can find and fix these issues, because why not :P This script is just run ad-hoc, so I think the potential impact is low. In part of this, I split out a function from a different script so that we can re-use it more easily.
I then used that script to fix all these issues.
Testing Instructions
code review. You can also execute the node scripts if you like (
node bin/packages/compare-local-package-versions-with-npm.js) and (node bin/packages/compare-local-package-versions-with-npm.js --fix).Testing Instructions for Keyboard
Screenshots or screencast