Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain argument to localization functions #5235

Merged
merged 2 commits into from Mar 7, 2018
Merged

Add domain argument to localization functions #5235

merged 2 commits into from Mar 7, 2018

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Feb 24, 2018

Description

This PR changes to domain-prefixed Jed functions.

Closes #5167.

How Has This Been Tested?

This has been tested with "npm test" and "npm run test-e2e".

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

aduth
aduth requested changes Feb 27, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you update the documentation at i18n/README.md as well?

@aduth aduth added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Feb 27, 2018
@Rahmon
Copy link
Contributor Author

Rahmon commented Feb 27, 2018

Sure. I'll do that.

aduth
aduth approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 I'm going to schedule this for the 2.4 milestone. Hopefully we can get a few of these related improvements in during the same release.

@aduth aduth added this to the 2.4 milestone Feb 28, 2018
@aduth aduth merged commit dcefc05 into WordPress:master Mar 7, 2018
@aduth aduth mentioned this pull request Mar 7, 2018
Merged
@Rahmon Rahmon deleted the fix/5167 branch March 15, 2018 13:05
@grappler grappler mentioned this pull request Mar 26, 2018
Closed
2 tasks
@mattyrob mattyrob mentioned this pull request Apr 4, 2018
Closed
@grappler grappler mentioned this pull request Apr 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

i18n: Add domain argument to localization functions
2 participants
@Rahmon @aduth