Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove padding support from Post Featured Image #52410

Closed

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Jul 7, 2023

Fixes: #52349

What?

This PR reverts padding support for Post Featured Image blocks added by #35775.

Why?

If you set padding like this issue, the border will be double marked up.
#52349
post-featured-image

Post Featured Image doesn't have content like Cover block, so I don't think it's necessary to set padding.

How?

Testing Instructions

In the trunk branch

  1. Open a Post or Page.
  2. Place a Post Featured Image block. If you haven't set an eye catch, set it.
  3. Set the border.
  4. Set overlay
  5. Set Padding
  6. You can see the overlayed border and two outer borders
  7. Switch to this branch to see the padding control disappear.
  8. Previously set spacing attributes are removed by the deprecated process.
    For example, the padding is removed when pasting the following HTML.
<!-- wp:post-featured-image {"overlayColor":"black","dimRatio":50,"style":{"spacing":{"padding":{"top":"clamp(1.875rem, 1.303rem + 1.83vw, 2.813rem)","bottom":"clamp(1.875rem, 1.303rem + 1.83vw, 2.813rem)","left":"var:preset|spacing|50","right":"var:preset|spacing|50"}},"border":{"width":"20px"}},"borderColor":"vivid-cyan-blue"} /-->

Testing Instructions for Keyboard

Screenshots or screencast

@skorasaurus skorasaurus added the [Block] Post Featured Image Affects the Post Featured Image Block label Jul 17, 2023
@Mamaduka Mamaduka added the Needs Design Feedback Needs general design feedback. label Jul 19, 2023
@Mamaduka Mamaduka requested a review from a team July 19, 2023 12:51
@jameskoster
Copy link
Contributor

I don't think we should remove the padding control on featured images, it limits design expression unnecessarily.

@jasmussen
Copy link
Contributor

I'd agree, the padding is valuable to have. Can we do something like this instead?

@shimotmk
Copy link
Contributor Author

shimotmk commented Aug 7, 2023

Since the specifications are not fixed, I will close it once.

@shimotmk shimotmk closed this Aug 7, 2023
@shimotmk shimotmk deleted the delete/padding-to-featured-image branch August 7, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Featured Image Affects the Post Featured Image Block Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Featured Image is double border marked up.
5 participants