Remove footnote from RichText toolbar if already present #52504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
[Type] Bug
|
Size Change: +20 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 094b137. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5519007809
|
|
See alternative #52506, which is currently my favourite. |
|
Closing in favour of #52506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Previously, clicking on the Footnote inline format in the RichText toolbar would always insert a new footnote, even if a footnote was already selected. With this pull request, footnotes behave like other formats, which means that the format button acts as a toggle:
Before
footnotes-toggle-format--before.mov
After
footnotes-toggle-format--after.mov
How?
As I understand it, footnotes are a slightly different RichText format. They aren't just a simple inline format, but a special object with a replacement. Notice how most formats are added with
applyFormat/toggleFormat, while for footnotes we resort toinsertObject. So my answer was to just remove the piece of RichText corresponding to the active object. I hope this is the right approach.Testing Instructions