Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Pattern title text clickable for 6.3 release #52599

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Make Pattern title text clickable for 6.3 release #52599

merged 1 commit into from
Jul 13, 2023

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jul 13, 2023 •
edited

What?

Re-implements #51898 as per #51898 (comment)

Why?

How?

Testing Instructions

  • Check the title below each Pattern can be clicked to enter focus mode for that Pattern
  • Make sure title's of Theme patterns cannot be clicked
  • Make sure only title's of custom patterns can be clicked.

Testing Instructions for Keyboard

Screenshots or screencast

Screen.Capture.on.2023-07-13.at.14-25-44.mp4

@getdave getdave changed the base branch from release/6.3 to release/16.2 July 13, 2023 13:28
@getdave getdave marked this pull request as ready for review July 13, 2023 13:30
@getdave getdave self-assigned this Jul 13, 2023
@getdave getdave added Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jul 13, 2023
@getdave getdave mentioned this pull request Jul 13, 2023
Merged
scruffian
scruffian approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scruffian scruffian merged commit 899a719 into release/16.2 Jul 13, 2023
2 checks passed
@scruffian scruffian deleted the fix/make-pattern-title-clickable branch July 13, 2023 14:00
@ockham ockham added Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release and removed Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release labels Jul 13, 2023
@ockham ockham added this to the Gutenberg 16.2 milestone Jul 13, 2023
@ockham
Copy link
Contributor

ockham commented Jul 13, 2023

Thank you, folks!

@aaronrobertshaw aaronrobertshaw mentioned this pull request Jul 18, 2023
Closed
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scruffian scruffian scruffian approved these changes

@ockham ockham Awaiting requested review from ockham

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@getdave getdave

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
Automattic team Ignite's project board
Archived in project
Milestone
Gutenberg 16.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@getdave @ockham @scruffian