Update e2e tests that use code editor #52788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
|
This should be safe to land. @kevin940726, do you have any notes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR makes the following changes in the
listandcontent-only-blockspecs:getByPlaceholderfor the code editor locator.Locator.fillto emulate paste. Thefillfocus element and then fill the content. This is all we need here.To be honest, I'm not sure how the list test passed before. When you run it in UI mode, you'll see that focus is on the post title during the paste action, but the content actually gets pasted in the code editor 🤷♂️
Why?
I'm suspicious that due to failed keyboard shortcut, code editor mode was leaking into other tests like - #51607 (comment).
It's a known issue that switching to a code editor can cause focus loss and prevent editor shortcuts from working - #42145. These changes ensure there's a focus after the initial switch.
Testing Instructions
CI checks should be green for these tests.