Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor navigation title usage #52807

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Refactor navigation title usage #52807

merged 2 commits into from
Jul 28, 2023

Commits on Jul 26, 2023

  1. Remove hotfixes for title.rendered from navigation block code 

    #52758 fixes the response from the fallback-navigation endpoint that did not have title.raw in the response, meaning we had to sometimes rely on title.rendered. This removes the extra 'or' statements that were added as hot fixes. The ones that still rely on title.rendered are due to the value needing to be checked within an object, or somewhere that the title property is not rendered via react.
    @jeryj @getdave
    jeryj authored and getdave committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    37522c9 View commit details
    Browse the repository at this point in the history

  2. Fix check for title.rendered when title.rendered might not be available

    @jeryj @getdave
    jeryj authored and getdave committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    7ed9723 View commit details
    Browse the repository at this point in the history