Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the block.json schema to include Behavior supports #52895

Merged
merged 2 commits into from Jul 24, 2023
Merged

Update the block.json schema to include Behavior supports #52895

merged 2 commits into from Jul 24, 2023

Conversation

michalczaplinski
Copy link
Contributor

Updates the schema for block.json files to include "supports": { "behaviors": "lightbox" }

Follow-up to #51156

Screen.Recording.2023-07-24.at.15.57.57.mov

@michalczaplinski michalczaplinski added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block [Type] Experimental Experimental feature or API. [Feature] Interactivity API API to add frontend interactivity to blocks. labels Jul 24, 2023
@michalczaplinski michalczaplinski changed the title Update the block.json to include Behavior supports Update the block.json schema to include Behavior supports Jul 24, 2023
@michalczaplinski michalczaplinski added [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Bug An existing feature does not function as intended labels Jul 24, 2023
@github-actions
Copy link

Flaky tests detected in 4d259d5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5646480354
📝 Reported issues:

@michalczaplinski michalczaplinski enabled auto-merge (squash) July 24, 2023 15:47
@michalczaplinski
Copy link
Contributor Author

Thanks @c4rl0sbr4v0 ! 👍

@michalczaplinski michalczaplinski merged commit eedff44 into trunk Jul 24, 2023
49 checks passed
@michalczaplinski michalczaplinski deleted the block-json-behaviors-schemas branch July 24, 2023 16:07
@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbravobernal cbravobernal cbravobernal approved these changes

@ajlende ajlende Awaiting requested review from ajlende

Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Code Quality Issues or PRs that relate to code quality [Type] Experimental Experimental feature or API.
Projects
None yet
Milestone
Gutenberg 16.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michalczaplinski @cbravobernal