Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce PR labels: Make PR label checks non-blocking to merge while trying a different GH token setting #52975

Merged
merged 1 commit into from Jul 26, 2023

Conversation

priethor
Copy link
Contributor

@priethor priethor commented Jul 26, 2023

Follow-up to #52760

What?

The action checking the PR labels is not working properly due to permission issues. This change tries using ${{ secrets.GITHUB_TOKEN }} instead of the default ${{ github.token }} as an alternative while making the label checks non-blocking to merge PRs.

Why?

As the action is currently failing, it will block PRs from being merged until fixed.

How?

By adding the exit_type: success property to the action settings.

@priethor priethor added the [Type] Project Management Meta-issues related to project management of Gutenberg label Jul 26, 2023
@priethor priethor requested a review from a team July 26, 2023 12:46
@priethor priethor self-assigned this Jul 26, 2023
@priethor priethor added [Type] Project Management Meta-issues related to project management of Gutenberg and removed [Type] Project Management Meta-issues related to project management of Gutenberg labels Jul 26, 2023
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try 👍

@priethor priethor changed the title Make PR label checks non-blocking to merge Make PR label checks non-blocking to merge while trying a different GH token setting Jul 26, 2023
@priethor
Copy link
Contributor Author

priethor commented Jul 26, 2023

Skipping the performance and e2e tests as this only changes GitHub action settings and this should not block other PRs 🙂

@priethor priethor merged commit c54dec5 into trunk Jul 26, 2023
54 checks passed
@priethor priethor deleted the automation/make-pr-label-checks-nonblocking branch July 26, 2023 13:23
@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 26, 2023
@priethor priethor added [Type] Project Management Meta-issues related to project management of Gutenberg and removed [Type] Project Management Meta-issues related to project management of Gutenberg labels Jul 26, 2023
@priethor priethor changed the title Make PR label checks non-blocking to merge while trying a different GH token setting Enforce PR labels: Make PR label checks non-blocking to merge while trying a different GH token setting Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants