Site Editor: Add navigation type to title labels map #53074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
This tests as advertised for me 👍
My only question is whether it should be Navigation Menu or Navigation as per the entity label in some other places e.g. here.
|
Yeah, I'm not entirely sure about that. @jameskoster, @richtabor, any suggestion on which label string we should use here? |
Mamaduka
force-pushed
the
fix/edit-site-navigation-menu-title
branch
from
236c10e
to
c3f4b14
Compare
|
Good question. 'Navigation menu' is used in the dark sidebar: 
But as @aaronrobertshaw pointed out it's just 'Navigation' in the Inspector: 
I don't know that we've really nailed down the terminology here so would welcome insight from @WordPress/gutenberg-design. My perception is that 'Navigation' is a label for the general menu management experience, and 'Navigation menu' refers to specific entries within that context. So in this case I'd lean towards the latter, and suggest that the Inspector should be updated to match. I do wonder if we could simplify though...
Iirc there were concerns about conflating 'menu' with restaurant menus, but given these menus live under the 'Navigation' umbrella I'm not sure how relevant that is. |
|
Thanks, @jameskoster! I'll merge this fix, and we can follow up with general changes once there's a consensus around terminology. |
|
Flaky tests detected in c3f4b14. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5689718776
|
|
Personally, I'll always prefer to call it purely "Navigation", and in every instance where we can, omit the term "Menu", exactly for the restaurant aspect mentioned. By being consistent with this, the term "Navigation" itself also gains further weight. Short and sweet. Not a strong opinion, and not blocking, but hey, there you go. |
|
I can live with; Editor → Navigation → Menu name 👍 |
|
I changed the label to "Navigation". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR adds the
wp_navigationlabel to the post-type label map for the Site Editor.P.S. I've not included this fix in #53071, since we can't backport new string in RCs.
Why?
It was incorrect.
Testing Instructions
Screenshots or screencast