Patterns: Show the default patterns icons for all pattern blocks in inserter #53208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
|
Size Change: +126 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
I have broken a unit test with this - will fix tomorrow |
|
Flaky tests detected in b5ce419. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5732180993
|
aaronrobertshaw
approved these changes
Aug 1, 2023
|
Thanks @glendaviesnz. This is working for me ✅ |
|
Unit test fix looks good and now passes. The iOS failure looks unrelated so I've hit re-run on that one. Once we're all green we should be able to merge. |
|
It could be cool to show the icon purple in the quick inserter search results. Has this been considered? |
@JosVelasco yes, there's an open issue for updating the icon color: #53209 |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Shows the default pattern icon for all user created patterns in the inserter
Why?
Currently the patterns attempt to show the outermost block icon which is confusing as it makes it hard to identify patterns in the inserter list.
Fixes: #51921
How?
Removes the code that tries to find the icon for the outermost block in a pattern and just defaults all to the standard pattern icon.
Testing Instructions
reusableScreenshots or screencast
Before:
pattern-icons-before.mp4
After:
icons-after.mp4