Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document title buttons radius #53221

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Update document title buttons radius #53221

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74fdd5c
Update document title buttons
jameskoster Aug 1, 2023
49e0857
button radius
jameskoster Aug 1, 2023
b554d6a
Merge branch 'trunk' into update/document-title-buttons
jameskoster Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/edit-site/src/components/header-edit-mode/document-actions/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
.edit-site-document-actions {
display: flex;
align-items: center;
gap: $grid-unit;
height: $button-size;
justify-content: space-between;
// Flex items will, by default, refuse to shrink below a minimum
Expand All @@ -10,7 +9,7 @@
// See https://dev.w3.org/csswg/css-flexbox/#min-size-auto
min-width: 0;
background: $gray-100;
border-radius: 4px;
border-radius: $grid-unit-05;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I could swear that box was 2px.

Since we're also using this border radius for modal dialogs (.components-modal__frame), should we make it a canonized variable like we have one for $radius-block-ui, and apply across both? Or is there a better system for handling the 3 radiuses we use at the moment (2, 4, 8)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes a little down the road I think we should consider this. Probably part of the upcoming component theming work.

width: min(100%, 450px);

// Make the document title shorter in top-toolbar mode, as it has to be covered.
Expand All @@ -19,6 +18,8 @@
}

.components-button {
border-radius: $grid-unit-05;

&:hover {
color: var(--wp-block-synced-color);
background: $gray-200;
Expand Down