Fix #52598 #53234
Closed
Fix #52598 #53234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UNTESTED my first try in TypeScript to fix auth issue in e2e-test-utlis-playwright
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @joostdekeijzer! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
skorasaurus
added
[Type] Automated Testing
|
#52598 is already fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Re #52598 (UNTESTED) my first try in TypeScript to fix auth issue in e2e-test-utlis-playwright
Why?
See issue #52598
How?
Swapping the definition of WP_ADMIN_USER and the other constants. Now using WP_USERNAME and WP_PASSWORD as input for WP_ADMIN_USER in stead of the other way around.
Testing Instructions
Sorry, untested. But #52625 is a test-use-case
Testing Instructions for Keyboard
Screenshots or screencast