Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I merged a fix to the IconButton component which adds a
text-indent
for when the component has text. This works because the SVG inside is not affected by text-indent.But the quick-shortcuts in the block appender wrap this icon with a
span
, which is affected by the text-indent.I can look for other solutions that do not rely on text-indent, but simply removing this span entirely seems to have no negative effects. Why was it added? No CSS appears to target the element.
In master:
In this branch: