Safari: fix ArrowUp on empty paragraph #53341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
requested review from
fluiddot,
dcalhoun,
kevin940726 and
Mamaduka
as code owners
ellatrix
force-pushed
the
fix/safari-arrow-up
branch
from
6290336
to
cf3416c
Compare
|
Size Change: -5 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
mtias
added
the
[Feature] Writing Flow
|
It's just a one line change and all e2e tests are passing, and I've added the test to be run in Firefox and webkit as well, so merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #53333.
Why?
Safari is tripping up on the placeholder (which is there for all empty paragraphs, but may be hidden with 0 opacity). Looking closer it seems
document.caretRangeFromPointis returningnullbecause the placeholder iscontenteditable="false".How?
The solution is the remove
contenteditable="false". The placeholder should be non editable, but I think removing this is fine because we already make the placeholder non selectable, so it shouldn't be possible tho edit it.Testing Instructions
In Safari, press ArrowUp in an empty paragraph preceded by another paragraph.
There's an existing e2e test, so I added it to be run on Firefox and Webkit as well. Indeed without the fix, this test was failing.
Testing Instructions for Keyboard
Screenshots or screencast