Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "post" from block titles #53492

Merged
merged 6 commits into from Aug 15, 2023
Merged

Remove "post" from block titles #53492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed28dce
Update doc
richtabor Aug 9, 2023
03b4eb5
Adjust titles
richtabor Aug 9, 2023
6894ba3
Update post-comments-form.test.js
richtabor Aug 10, 2023
6bc6a1c
Update pages.spec.js
richtabor Aug 10, 2023
68d0d35
Make changes per feedback
richtabor Aug 11, 2023
2b1619a
Fix tests
richtabor Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 11 additions & 11 deletions docs/reference-guides/core-blocks.md
View file
Open in desktop
Expand Up @@ -491,7 +491,7 @@ Show a block pattern. ([Source](https://github.com/WordPress/gutenberg/tree/trun
- **Supports:** ~~html~~, ~~inserter~~
- **Attributes:** slug

## Post Author
## Author

Display post author details such as name, avatar, and bio. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-author))

Expand All @@ -500,7 +500,7 @@ Display post author details such as name, avatar, and bio. ([Source](https://git
- **Supports:** color (background, gradients, link, text), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~
- **Attributes:** avatarSize, byline, isLink, linkTarget, showAvatar, showBio, textAlign

## Post Author Biography
## Author Biography

The author biography. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-author-biography))

Expand All @@ -509,7 +509,7 @@ The author biography. ([Source](https://github.com/WordPress/gutenberg/tree/trun
- **Supports:** color (background, gradients, link, text), spacing (margin, padding), typography (fontSize, lineHeight)
- **Attributes:** textAlign

## Post Author Name
## Author Name

The author name. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-author-name))

Expand All @@ -518,7 +518,7 @@ The author name. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/pac
- **Supports:** color (background, gradients, link, text), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~
- **Attributes:** isLink, linkTarget, textAlign

## Post Comment (deprecated)
## Comment (deprecated)

This block is deprecated. Please use the Comments block instead. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-comment))

Expand All @@ -528,7 +528,7 @@ This block is deprecated. Please use the Comments block instead. ([Source](https
- **Supports:** ~~html~~, ~~inserter~~
- **Attributes:** commentId

## Post Comments Count
## Comments Count

Display a post's comments count. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-comments-count))

Expand All @@ -538,7 +538,7 @@ Display a post's comments count. ([Source](https://github.com/WordPress/gutenber
- **Supports:** color (background, gradients, text), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~
- **Attributes:** textAlign

## Post Comments Form
## Comments Form

Display a post's comments form. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-comments-form))

Expand All @@ -547,7 +547,7 @@ Display a post's comments form. ([Source](https://github.com/WordPress/gutenberg
- **Supports:** color (background, gradients, heading, link, text), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~
- **Attributes:** textAlign

## Post Comments Link
## Comments Link

Displays the link to the current post comments. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-comments-link))

Expand All @@ -557,7 +557,7 @@ Displays the link to the current post comments. ([Source](https://github.com/Wor
- **Supports:** color (background, link, ~~text~~), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~
- **Attributes:** textAlign

## Post Content
## Content

Displays the contents of a post or page. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-content))

Expand All @@ -566,9 +566,9 @@ Displays the contents of a post or page. ([Source](https://github.com/WordPress/
- **Supports:** align (full, wide), color (background, gradients, link, text), dimensions (minHeight), layout, typography (fontSize, lineHeight), ~~html~~
- **Attributes:**

## Post Date
## Date

Add the date of this post. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-date))
Display the publish date for an entry such as a post or page. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-date))

- **Name:** core/post-date
- **Category:** theme
Expand All @@ -584,7 +584,7 @@ Display the excerpt. ([Source](https://github.com/WordPress/gutenberg/tree/trunk
- **Supports:** color (background, gradients, link, text), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~
- **Attributes:** excerptLength, moreText, showMoreOnNewLine, textAlign

## Post Featured Image
## Featured Image

Display a post's featured image. ([Source](https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/post-featured-image))

Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-author-biography/block.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://schemas.wp.org/trunk/block.json",
"apiVersion": 3,
"name": "core/post-author-biography",
"title": "Post Author Biography",
"title": "Author Biography",
"category": "theme",
"description": "The author biography.",
"textdomain": "default",
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-author-name/block.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://schemas.wp.org/trunk/block.json",
"apiVersion": 3,
"name": "core/post-author-name",
"title": "Post Author Name",
"title": "Author Name",
"category": "theme",
"description": "The author name.",
"textdomain": "default",
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-author/block.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://schemas.wp.org/trunk/block.json",
"apiVersion": 3,
"name": "core/post-author",
"title": "Post Author",
"title": "Author",
"category": "theme",
"description": "Display post author details such as name, avatar, and bio.",
"textdomain": "default",
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-comment/block.json
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
"apiVersion": 3,
"__experimental": "fse",
"name": "core/post-comment",
"title": "Post Comment (deprecated)",
"title": "Comment (deprecated)",
"category": "theme",
"description": "This block is deprecated. Please use the Comments block instead.",
"textdomain": "default",
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-comments-count/block.json
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
"apiVersion": 3,
"__experimental": "fse",
"name": "core/post-comments-count",
"title": "Post Comments Count",
"title": "Comments Count",
"category": "theme",
"description": "Display a post's comments count.",
"textdomain": "default",
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-comments-form/block.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://schemas.wp.org/trunk/block.json",
"apiVersion": 3,
"name": "core/post-comments-form",
"title": "Post Comments Form",
"title": "Comments Form",
"category": "theme",
"description": "Display a post's comments form.",
"textdomain": "default",
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-comments-link/block.json
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
"apiVersion": 3,
"__experimental": "fse",
"name": "core/post-comments-link",
"title": "Post Comments Link",
"title": "Comments Link",
"category": "theme",
"description": "Displays the link to the current post comments.",
"textdomain": "default",
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-content/block.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://schemas.wp.org/trunk/block.json",
"apiVersion": 3,
"name": "core/post-content",
"title": "Post Content",
"title": "Content",
richtabor marked this conversation as resolved.
Show resolved Hide resolved
"category": "theme",
"description": "Displays the contents of a post or page.",
"textdomain": "default",
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/post-date/block.json
View file
Open in desktop
Expand Up @@ -2,9 +2,9 @@
"$schema": "https://schemas.wp.org/trunk/block.json",
"apiVersion": 3,
"name": "core/post-date",
"title": "Post Date",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just date is confusing as it could just as well be the current date. Maybe this should just be called Published Date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, maybe so. 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling it "published date" would help separate it from the "modified date" variation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a bit weird for me to see modified date as a variation in the inserter. I'd expect it to be a single date block and for modified to be a property there.

"title": "Date",
"category": "theme",
"description": "Add the date of this post.",
"description": "Display the publish date for an entry such as a post or page.",
"textdomain": "default",
"attributes": {
"textAlign": {
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-date/variations.js
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ import { postDate } from '@wordpress/icons';
const variations = [
{
name: 'post-date-modified',
title: __( 'Post Modified Date' ),
title: __( 'Modified Date' ),
description: __( "Display a post's last updated date." ),
attributes: { displayType: 'modified' },
scope: [ 'block', 'inserter' ],
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-featured-image/block.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://schemas.wp.org/trunk/block.json",
"apiVersion": 3,
"name": "core/post-featured-image",
"title": "Post Featured Image",
"title": "Featured Image",
"category": "theme",
"description": "Display a post's featured image.",
"textdomain": "default",
Expand Down
4 changes: 2 additions & 2 deletions packages/e2e-tests/specs/experiments/blocks/post-comments-form.test.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ import {
canvas,
} from '@wordpress/e2e-test-utils';

describe( 'Post Comments Form', () => {
describe( 'Comments Form', () => {
let previousCommentStatus;

beforeAll( async () => {
Expand Down Expand Up @@ -42,7 +42,7 @@ describe( 'Post Comments Form', () => {
await enterEditMode();

// Insert post comments form
await insertBlock( 'Post Comments Form' );
await insertBlock( 'Comments Form' );

// Ensure the placeholder is there
await expect( canvas() ).toMatchElement(
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/specs/site-editor/pages.spec.js
View file
Open in desktop
Expand Up @@ -54,7 +54,7 @@ test.describe( 'Pages', () => {
// Insert into Page Content using appender.
await page
.getByRole( 'region', { name: 'Editor footer' } )
.getByRole( 'button', { name: 'Post Content' } )
.getByRole( 'button', { name: 'Content' } )
.click();
await editor.canvas
.getByRole( 'button', { name: 'Add block' } )
Expand Down Expand Up @@ -90,7 +90,7 @@ test.describe( 'Pages', () => {
.click();
await expect(
editor.canvas.getByRole( 'document', {
name: 'Block: Post Content',
name: 'Block: Content',
} )
).toContainText(
'This is the Post Content block, it will display all the blocks in any single post or page.'
Expand Down
2 changes: 1 addition & 1 deletion test/performance/specs/site-editor.spec.js
View file
Open in desktop
Expand Up @@ -170,7 +170,7 @@ test.describe( 'Site Editor Performance', () => {

// Insert a new paragraph right under the first one.
await canvas
.getByRole( 'document', { name: 'Block: Post Content' } )
.getByRole( 'document', { name: 'Block: Content' } )
.click();
await firstParagraph.click();
await pageUtils.pressKeys( 'primary+a' );
Expand Down