Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Block Variations API doc. #53817

Merged
merged 2 commits into from Aug 18, 2023
Merged

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 18, 2023

What?

The existing Block Variations API doc lacked some clarity around the different properties available and several caveats to be aware of when working with variations.

More examples could definitely be added to the doc, but that's beyond the scope of this initial update.

Why?

Provide a better developer experience for those working with block variations.

@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Aug 18, 2023
@ndiego ndiego self-assigned this Aug 18, 2023
@ndiego ndiego marked this pull request as ready for review August 18, 2023 17:42
@ndiego ndiego requested a review from carolinan August 18, 2023 17:51
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Flaky tests detected in e9979eb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5905823604
📝 Reported issues:

Copy link
Contributor

@justintadlock justintadlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndiego ndiego merged commit c6bf0d0 into trunk Aug 18, 2023
49 checks passed
@ndiego ndiego deleted the update/block-variations-doc branch August 18, 2023 19:42
@github-actions github-actions bot added this to the Gutenberg 16.6 milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants