Fix the useSelect warning of the “Copy all blocks” menu item
#53833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Code Quality
|
Size Change: -2 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
We already had #53676 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Avoids the console warning about changing return value of
useSelect.Why?
To keep the console cleaner. In this case it doesn't seem like the changing return value would cause extra renders or be otherwise problematic so this is just nice to have.
How?
Use
selectinstead ofuseSelect.At first, I tried returning
getEditedPostAttributefrom the hook’s callback but that doesn't avoid the warning because it isn't a memoized selector. I assumed it's not memoized for a reason. I hope a reviewer may know better. Even were it memoized I'm not aware of the advantageuseSelectwould provide in this specific case.Testing Instructions
useSelecthookTesting Instructions for Keyboard
I think the instructions above work
Screenshots or screencast
Before
edit-post-copy-all-use-select-warning.mp4
After
edit-post-copy-all-use-select-warning-fixed.mp4