New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification for parent
and ancestor
hierarchical relationships
#53855
Clarification for parent
and ancestor
hierarchical relationships
#53855
Conversation
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
parent
and ancestor
hierarchical relationships
I think that is an oxymoron. 🙃 |
I'm also wondering if replacing some of the "context" uses with "inheritance" might help. I think the term "context" might get easily confused with Block Context. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab at this documentation :) I have raised a few concerns and tried to leave some suggestions. (May be a little messy though)
In general I am not a fan of using the hierarchical relationships
reference in this documentation but have left some more detailed notes inline :)
Let me know what you think!
docs/how-to-guides/block-tutorial/nested-blocks-inner-blocks.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/nested-blocks-inner-blocks.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/nested-blocks-inner-blocks.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/nested-blocks-inner-blocks.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/nested-blocks-inner-blocks.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/nested-blocks-inner-blocks.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/block-tutorial/nested-blocks-inner-blocks.md
Outdated
Show resolved
Hide resolved
@fabiankaegy All your suggestions were great, and I appreciate the feedback. I had already rewritten some of the content because I'm also writing documentation for ACF Blocks InnerBlocks, and many of these concepts are bouncing around in my head for the best way to try and explain them. I read through your comments. I generally agree with all of your observations. I took another broad pass at the overall approach. I would love another round of feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the updates you made now :)
Haha that was perfect timing. I saw you had pushed a new revision and just finished reading it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks! 🚢
Excellent job rephrasing the subtle differences between these two options. The cool part is that folks can even use both |
What?
Attempting to offer clarity on the usage of
parent
andancestor
hierarchical relationship in InnerBlocks nesting.Some notes:
Why?
Hierarchical relationshiops can be hard to explain.
How?
Change wording.
Testing Instructions
Just a docs change and compare the diff is probably best.
Testing Instructions for Keyboard
Not applicable.