Site Logo: Remove line-height for the anchor element #53909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 24, 2023
Test ReportLGTM 👍🏻 Environment
Actual Results
Supplemental ArtifactsBefore patch: After patch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported by @Ren2049 in the create-block-theme project: WordPress/create-block-theme#432
Follow-up on #27623
What?
This PR fixes a problem where the line-height of the link text affects the height of the Site Logo block.
Why?
By #27623,
line-height:0has been added to the root block element to avoid the influence of the global line-height. However, the current global style allows the line-height to be set on the link element as well, so the anchor element inside is affected.How?
Added line-height: 0 to anchor elements as well. This should not be a problem since this block has no text.
Testing Instructions