Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 16 and npm 8 in the getting started with code contribution doc #53912

Merged

Conversation

jblz
Copy link
Contributor

@jblz jblz commented Aug 24, 2023

What?

Correct an outdated reference to node and npm versions in the "Getting Started with Code Contribution" doc

Why?

Bring docs in line with the versions we're using:

gutenberg/package.json

Lines 17 to 20 in bc94b20

"engines": {
"node": ">=16.0.0",
"npm": ">=8 <9"
},

16

How?

simple doc update

Testing Instructions

n/a

Testing Instructions for Keyboard

n/a

Screenshots or screencast

n/a

@github-actions
Copy link

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Aug 24, 2023
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexstine alexstine merged commit 093dad6 into WordPress:trunk Aug 25, 2023
49 of 54 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.6 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants