Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefixes all php filters with wpdocs_ #53914

Merged
merged 1 commit into from Jan 23, 2024
Merged

Prefixes all php filters with wpdocs_ #53914

merged 1 commit into from Jan 23, 2024

Conversation

bacoords
Copy link
Contributor

What?

Closes #53567 by modifying the prefix for PHP filter examples

@aurooba aurooba added the [Type] Developer Documentation Documentation for developers label Aug 24, 2023
ryanwelcher
ryanwelcher approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great.

@t-hamano
Copy link
Contributor

Hi @bacoords,

Could you resolve the conflict by rebasing to merge this PR?

@bacoords
Copy link
Contributor Author

@t-hamano

I've updated my branch. From what I can tell, the old docs/getting-started/create-block tutorial is basically gone and replaced with https://github.com/WordPress/gutenberg/blob/trunk/docs/getting-started/devenv/get-started-with-create-block.md which doesn't have the same code snippets so this PR should be ready.

@t-hamano t-hamano self-requested a review January 23, 2024 06:15
t-hamano
t-hamano approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. It looks to me that all prefixes are updated properly 👍

@t-hamano t-hamano merged commit cf3dbbc into WordPress:trunk Jan 23, 2024
54 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.6 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmaguitar juanmaguitar juanmaguitar approved these changes

@ryanwelcher ryanwelcher ryanwelcher approved these changes

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 17.6
Development

Successfully merging this pull request may close these issues.

Documentation: Use consistent prefixes in code examples
5 participants
@bacoords @t-hamano @juanmaguitar @ryanwelcher @aurooba