Search block: Fix width input field #53952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Type] Bug
|
Size Change: +23 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f3b6753. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5977785501
|
Mamaduka
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the search block: Change the input width
minvalue to a number to fix a bug and add amaxvalue if the unit it %.Why?
The input width field isn't working as it should when the
minvalue is a string that includes the unit. Arrow-up, arrow-down and the drag behavor all resets the input field to0.How?
Change the
minprop to be a number. Have also optimized the min/max value based on the unit.Testing Instructions
Screenshots or screencast
Before
Skjermopptak.2023-08-25.kl.17.36.01.mov
After
Skjermopptak.2023-08-25.kl.17.34.56.mov