Cover block: fix exception when adding video background #53961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
@ajlende we have been passing video to |
|
Size Change: +28 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8efe2ea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5993718106
|
aaronrobertshaw
approved these changes
Aug 26, 2023
There was a problem hiding this comment.
Appreciate the quick fix @glendaviesnz 👍
✅ Could replicate the initial issue
✅ After checking out this PR, I can successfully add a video, with no errors
Screen.Recording.2023-08-26.at.4.20.25.pm.mp4
|
Given that video was just failing by default previously I think this is a reasonable fix. We can follow up if we decide we do want to support video somehow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes exception that is thrown if video is added as cover background.
Why?
Adding a video causes fastAverageColor to throw an exception. This was an existing problem but was previously masked by the fact that the exception was thrown in an effect, but now that the check is done in an event handle it disrupts the attribute update process.
Fixes: #53956
How?
Wraps the call to fastAverageColor in a try/catch and also only passes images to this call, not video.
Testing Instructions
Screenshots or screencast
Before:
cover-bug-before.mp4
After:
cover-bug-after.mp4