Add block-specific commands as contextual suggestions [#53539]

[jrtashjian]

What?

This PR adds a new context named block-selection-edit which is applied to the command palette when a block (or group of blocks) are selected. This allows us to show the block actions in the command palette immediately rather than searching for them.

Why?

Related to #53539, closes #53539.

How?

By adding additional logic to the edit-site and edit-post packages (when context is set) we can apply our new context. I could use assistance improving this to simplify the logic maybe with global context conditions that can be defined in one place rather than duplicating code.

Testing Instructions

1. Open a post, page, or template.
2. Without selecting a block open up the command palette. You should not see any block action commands (group/ungroup, add before/after, etc).
3. Now select a block or multiple blocks and open up the command palette again. You should see any block action commands for the selected block (group/ungroup, add before/after, etc).

Testing Instructions for Keyboard

Screenshots or screencast

[ntsekouras]

Thanks for the PR @jrtashjian! I'll cc @WordPress/gutenberg-design for any input about the UX and the prominence of these commands.

[ntsekouras]

We already have the hook in edit post here.

[jrtashjian]

I can remove it from the Editor component and leave it where I initially added it in the Layout component. This will make sure things stay consistent between edit-post and edit-site packages.

[jrtashjian]

Done in 5e96629.

[jameskoster]

I think it looks good. The pencil icon for the Remove action threw me though. Should that use the trash icon instead?

[jrtashjian]

@jameskoster this PR only exposes the existing commands in a contextual matter. I know these block level actions were recently merged into trunk though. I can update this branch with the latest on trunk to see if icons have been tweaked.

[jrtashjian]

Looks like no changes to the icons on trunk but I did run across this follow up issue for tweaking the icons: #53538

[jrtashjian]

I've just pushed another PR up for those icon fixes mentioned in the issue I found: #54427

[richtabor]

Solid.

Can we also get them in the same order as the block options menu? And let's take out "Move to" from the contextual suggestions.

• Duplicate
• Add before
• Add after
• Group
• Ungroup (only shows up when selecting a group)
• Delete

[jrtashjian]

Done. Because of how useCommandLoader functions by giving context to groups of commands, I decided to split the commands into two separate command loaders. This split gives us the ability to control exactly which commands appear in the palette.

• useActionsCommands registers the command with the palette.
• useQuickActionsCommands registers the command within a context in the palette.

Re-ordered and removed "Move to"

"Move to" is still available when searching

Example with group block selected

[draganescu]

Good idea with the special quick actions loader, it's the only way to filter out what we don't want to show in quick actions. Otherwise the code looks good.

It also tested well for me.

[richtabor]

LGTM

[richtabor]

@jrtashjian mind rebasing, running the checks again?

[jrtashjian]

I rebased but there still seems to be a failing test. It's definitely unrelated to the command palette though. I'm not super familiar with the test suite yet but if someone else is able to help resolve it, I'd appreciate it.

[richtabor]

@jrtashjian do you mind rebasing/seeing if that fixes the test? 🙇‍♂️

[jrtashjian]

@richtabor ok, rebased again and it looks like the previously failing tests passed. However the Performance Tests are taking quite a while to run.