Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date: update translation domains for strings to be translatable #53995

Merged
merged 1 commit into from Aug 28, 2023

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Aug 28, 2023

Follow-up to #53931
Related conversation #53888 (comment)

What

Updates the translation domain of some strings.

Why

Otherwise:

  1. Relative time strings won't be translatable unless Gutenberg is using a WordPress versions in which they are. The sooner this could be the to be released WordPress 6.4.
  2. Existing format strings were merged into WordPress core 5 years ago (see git blame), so they are already translated by core. Given Gutenberg is not redefined them, we can use the existing core strings.

@oandregal oandregal self-assigned this Aug 28, 2023
@oandregal oandregal added Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Date /packages/date Needs PHP backport Needs PHP backport to Core labels Aug 28, 2023
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.4/script-loader.php

@oandregal oandregal added the [Type] Bug An existing feature does not function as intended label Aug 28, 2023
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating and for linking through to the discussion!

@ramonjd ramonjd merged commit 58f5e9a into trunk Aug 28, 2023
51 of 59 checks passed
@ramonjd ramonjd deleted the update/translation-domain-wp-date branch August 28, 2023 23:54
@github-actions github-actions bot added this to the Gutenberg 16.6 milestone Aug 28, 2023
@ramonjd
Copy link
Member

ramonjd commented Aug 28, 2023

PHP backport here: WordPress/wordpress-develop#5101

I'll remove the label.

Thanks a lot for this PR and solving the context question!

@ramonjd ramonjd removed the Needs PHP backport Needs PHP backport to Core label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Date /packages/date [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants