Composite: refactor to TypeScript #54028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
ciampo
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
LGTM 🚀
Would you mind adding an entry to the CHANGELOG in the Unreleased section, under an Internal sub-section? (here's an example of a similar entry)
We can merge as soon as that's done!
margolisj
force-pushed
the
Composite-typescript
branch
from
c233dde
to
3cac5bc
Compare
|
@ciampo Added changelog and rebased from current trunk. |
ciampo
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrading Composite component to Typescript.
Why?
Typescript is the only sane was to maintain a codebase this large.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast