Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownMenu v2: Fix submenu chevron direction in RTL languages #54036

Merged
merged 5 commits into from Sep 5, 2023

Conversation

walbo
Copy link
Member

@walbo walbo commented Aug 29, 2023

What?

Make sure the RTL styles are beeing applied for the submenu trigger item.

Why?

The arrows should point the other way for RTL languages.

How?

Fix how RTL styles are added.

Testing Instructions

  1. Open up storybook and navigate to the dropdown v2 component.
  2. Enable RTL
  3. Confirm the arrows point to the left on the submenu trigger item.

Screenshots or screencast

Before After
image image

@walbo walbo added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Aug 29, 2023
@walbo walbo requested a review from ciampo August 29, 2023 17:50
@walbo walbo requested a review from ajitbohra as a code owner August 29, 2023 17:50
@walbo walbo self-assigned this Aug 29, 2023
@github-actions
Copy link

Flaky tests detected in 392b882.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6015849821
📝 Reported issues:

Copy link
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works both in LTR and RTL. LGTM!

Screenshot 2023-08-29 at 1 55 48 PM Screenshot 2023-08-29 at 1 56 01 PM

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you, @walbo (good to see you around again!)

Interesting that our static linting tools didn't pick up the error.

@walbo walbo merged commit ed1a95b into trunk Sep 5, 2023
50 checks passed
@walbo walbo deleted the fix/dropdownmenuv2-submenu-chevron-dir branch September 5, 2023 18:03
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants